ReportForm: Check whether the report name is unique #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix/dont-show-sql-error
branch
from
d56c520 to
c4a7c6e
Compare
raviks789
reviewed
Sep 24, 2024
Comment on lines
122
to
124
| if ($value === null) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This is unnecessary. As the field is required, the value is never null.
The form now requires a database instance (RetryConnection), which should be specified as a constructor parameter in order to keep the form dependency-free.
sukhwinder33445
force-pushed
the
fix/dont-show-sql-error
branch
from
c4a7c6e to
137f4ac
Compare
raviks789
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #218